[X] My Assistant

So line 84 is this?

CODE

            '& times=' + timestamp : '');

No, it's

CODE

            '& timestamp=' + timestamp : '');

(remove space after &).

Been getting this error on console.

TypeError: window.location.href.match(...) is null[Learn More] EH_Gallery_Download_Shortcuts_(Emergency_Release).user.js:408:34

Any idea what this means?

Seems like something goes really wrong.

Laden fehlgeschlagen für das <script> mit der Quelle "https://adserver.juicyads.com/js/jads.js". dbcc9829ea:21:1
Laden fehlgeschlagen für das <script> mit der Quelle "https://adserver.juicyads.com/js/jads.js". 2 dbcc9829ea:37:1
[Exception... "Component returned failure code: 0x80004005 (NS_ERROR_FAILURE) [nsIDOMWindowUtils.removeSheetUsingURIString]" nsresult: "0x80004005 (NS_ERROR_FAILURE)" location: "JS frame :: resource://gre/modules/ExtensionCommon.jsm :: runSafeSyncWithoutClone :: line 65" data: no] ExtensionCommon.jsm:65:12
Laden fehlgeschlagen für das <script> mit der Quelle "https://adserver.juicyads.com/js/jads.js". dbcc9829ea:21:1
Laden fehlgeschlagen für das <script> mit der Quelle "https://adserver.juicyads.com/js/jads.js". 2 dbcc9829ea:37:1

German, but should still make sense. Loading of a script with the source of that link fails. Not sure why that adserver link would get mentioned in the first place.

edit: This might've been a noscript thing, but the error still happens.

[Exception... "Component returned failure code: 0x80004005 (NS_ERROR_FAILURE) [nsIDOMWindowUtils.removeSheetUsingURIString]" nsresult: "0x80004005 (NS_ERROR_FAILURE)" location: "JS frame :: resource://gre/modules/ExtensionCommon.jsm :: runSafeSyncWithoutClone :: line 65" data: no] 10 ExtensionCommon.jsm:65:12
Promise rejected after context unloaded: Promised response from onMessage listener went out of scope
30 toolbarContentscript.js:7
<anonym> moz-extension://d344bc30-332d-4be4-8bab-00d918d28d31/contentscripts/toolbarContentscript.js:7
Error: Promised response from onMessage listener went out of scope 10 ExtensionMessagingService.js:89:34

Is this a greasemonkey issue? Honestly, the console gets spammed the entire time with issues, even after closing the tab with the favorites, only being in this forum.

This post has been edited by killi890: Jul 27 2019, 11:41

Here's another error to figure out. I've been fighting all night to get this script to download more than a single gallery before shitting the bed and I'm tired.

[/quote]Uncaught TypeError: Cannot read property '1' of null
at catchTorrentList (userscript.html?id=510b3a3d-7b57-4ced-a310-a27f1921d9b5:414)
at Window.addDownloadShortcuts (userscript.html?id=510b3a3d-7b57-4ced-a310-a27f1921d9b5:469)
at <anonymous>:2:494
at c.<computed> (eval at exec_fn (favorites.php:1), <anonymous>:55:182)
at <anonymous>:2:494
at b (<anonymous>:1:414)
at <anonymous>:2:494
at ka (eval at exec_fn (favorites.php:1), <anonymous>:55:208)
at l (eval at exec_fn (favorites.php:1), <anonymous>:53:60)[quote]

It also gets hung up on any gallery that 404s. It'll just keep trying to download it over and over in vain instead of moving on to the next one.

This post has been edited by MapleSyrup: Jul 27 2019, 13:58

Edit:

I think it's caused by earlier on in your code,

'×tamp='

Is it supposed to be "×" (U+00D7, a non-ascii character)?

Ok, it looks like "& times" (no space) got converted to × here.

Maybe a good time to consider host the code to somewhere more dedicated like gist.github or pastebin (IMG:[invalid] style_emoticons/default/biggrin.gif)

The latest script seems to get stuck on Loading if a gallery has a torrent. I checked the gallery and it didn't spend GP, so it seems like fetching the torrent itself is causing it to get stuck. fireattack's correction fixed it. Otherwise, thanks for this, very useful.

I agree on a Github to more easily follow updates. Also, you should implement a wait between downloads so it doesn't trigger Ex's temporary IP ban for excessive pageloads.

Been getting this error on console.
Any idea what this means?

Here's another error to figure out. I've been fighting all night to get this script to download more than a single gallery before shitting the bed and I'm tired.

Uncaught TypeError: Cannot read property '1' of null
at catchTorrentList (userscript.html?id=510b3a3d-7b57-4ced-a310-a27f1921d9b5:414)
at Window.addDownloadShortcuts (userscript.html?id=510b3a3d-7b57-4ced-a310-a27f1921d9b5:469)
at <anonymous>:2:494
at c.<computed> (eval at exec_fn (favorites.php:1), <anonymous>:55:182)
at <anonymous>:2:494
at b (<anonymous>:1:414)
at <anonymous>:2:494
at ka (eval at exec_fn (favorites.php:1), <anonymous>:55:208)
at l (eval at exec_fn (favorites.php:1), <anonymous>:53:60)

It also gets hung up on any gallery that 404s. It'll just keep trying to download it over and over in vain instead of moving on to the next one.

It also gets hung up on any gallery that 404s. It'll just keep trying to download it over and over in vain instead of moving on to the next one.

Yes, it is the the forum's autocorrect that changed the code. I do not know why "& times" is a particular problem, when other phrases like "&timer" are not. I will move it to Github, like I have always wanted, since I have time now. You guys did not see it, but yesterday was a panic and I did not have time to say anything at first, so I just put the code up here, which at least contained some descriptions at that time.

Alright got it working on chrome thankfully. But it keeps missing 4-5 galleries on each page (why ?) have to download them manually.

Is there any fix for that (rest is working excellent)

@rraven314 really grateful to you kind Sir god bless (IMG:[invalid] style_emoticons/default/smile.gif)

I need more descriptions. Do the individual download buttons say "done", but the corresponding galleries did not actually get downloaded? Are these missing downloads torrents or archives?

I cannot access to most of the galleries I have in my favs even though I can see the thumbnail, they all say "has been removed or is unavailable". Does this mean they're gone for good?

Most likely.

One other minor suggestion if you feel like it: an option (could just be commented out) to rate any downloaded galleries and skip any rated ones as a sort of ghetto "permanent download indicator". Won't work for everyone, but I've been using "just give it 4 stars" as a way to note to myself what I've already saved. Not like ratings matter much anymore (well, not that they have ever mattered that much).

I cannot add this, because:

1. This is not safe. Because ratings probably apply to gallery chains, updated galleries will keep this permanent download indicator and the script would then skip them. Therefore you will miss all updated galleries. Adding them to favorites will not work either.

2. This is misuse. It is not how the ratings are supposed to be used so, having manned this help desk subforum for two or three years, I would avoid this and try not to make the ratings more inaccurate.

Seems like something goes really wrong.
German, but should still make sense. Loading of a script with the source of that link fails. Not sure why that adserver link would get mentioned in the first place.

edit: This might've been a noscript thing, but the error still happens.
Is this a greasemonkey issue? Honestly, the console gets spammed the entire time with issues, even after closing the tab with the favorites, only being in this forum.

I do not think it is my script.

It also gets hung up on any gallery that 404s. It'll just keep trying to download it over and over in vain instead of moving on to the next one.

Does it show failed? I cannot easily test this, but it is probably because I have made some unusual edits to the code and put it in ignore-failure mode so that it is quicker to retry these galleries. As I stated in the first post, this is intentional at the moment.

Most of us are desperately trying to save our favorites through fair means or foul.

I saw anons talking about mods giving out free credits for this specific purpose.
If this is true, why not remove the cost entirely? And please let me download what's left of my favorites - I can't afford to save everything.

Giving unrestrained downloading to our entire userbase without discretion would melt the servers.

The latest script seems to get stuck on Loading if a gallery has a torrent. I checked the gallery and it didn't spend GP, so it seems like fetching the torrent itself is causing it to get stuck. fireattack's correction fixed it. Otherwise, thanks for this, very useful.

I agree on a Github to more easily follow updates. Also, you should implement a wait between downloads so it doesn't trigger Ex's temporary IP ban for excessive pageloads.

I second this delay between downloads as I just hit the temporary IP ban as well.

I agree on a Github to more easily follow updates. Also, you should implement a wait between downloads so it doesn't trigger Ex's temporary IP ban for excessive pageloads.

I second this delay between downloads as I just hit the temporary IP ban as well.

Did you guys spam the batch download button too fast or increased the batch size? I mentioned in the descriptions that spamming it can get you banned. Also, are you sure you are not using shared IPs in general? I think a cooldown between batch downloads is generally not necessary and would be very annoying for users who use it more reasonably.

Plus there is no hurry now. Just earn your money and download normally. The exchange rates are bad for credit and hath, though.

Giving unrestrained downloading to our entire userbase without discretion would melt the servers.

What about having e-hentai galleries hidden from searching but unlocked on e-hentai, with all the credit restrictions remaining, so that they can be archived slowly but steadily by everyone in the next one more years to come.

Hi guys. I have links, but how can I find out from them the name of the gallery?

Paste the links.

Here's a thought. Perhaps our less fortunate users can make a list of titles for the galleries they want and us filthy rich monopoly money carriers can make batch downloads of them on hosts like mega, sendspace or google drive.

Yesterday I saw some kind soul just making bounties with free credits for anyone who was fast enough.

People have been requesting stuff on forum here and in 4chan thread and most have been filled. There is a requests subforum here, which should be more appropriate for this.
As more people will finish with their own favs, more will be willing to fill others' requests.

Hi guys. I have links, but how can I find out from them the name of the gallery?

Paste the links.

Here's a thought. Perhaps our less fortunate users can make a list of titles for the galleries they want and us filthy rich monopoly money carriers can make batch downloads of them on hosts like mega, sendspace or google drive.

I pray for your private message inbox. (IMG:[invalid] style_emoticons/default/rolleyes.gif)

I pray for your private message inbox. (IMG:[invalid] style_emoticons/default/rolleyes.gif)

Yeeeah, nah. If they wanna spam requests for fap stamps they can do it in this thread, where multiple people will see it. Welfare works better that way.

I pray for your private message inbox. (IMG:[invalid] style_emoticons/default/rolleyes.gif)

I lost hard.