[X] My Assistant

- Replaced operator '!=' and '==' with '!==' and '===' to avoid implicit type conversion.

I was personally very happy with this update.
It introduced a couple of bugs due to previous lazy coding but they're easy enough to fix.
Thanks again.

As I appreciate you guys' work, you are also making the whole project as chaoic as ever.

1. I do think most people would like to have 1 patch in 2-3 weeks which contains several updates rather than 14 patches everyone which contains a bit of improvement. Just see how many patches you guys have posted in the last few days.
Just don't rush to name every update first: test it among yourselves, see if there's any problems, then publish that in a package. This has become a collaborated work, so please make it work like a collaborated work instead of several individual small improvements made by separate people.

As Ilirith said, people don't have to update everytime. I'd probably recommend waiting for a 1.1.* release (under the current version sys we've been using).
From now on though, I'll include a stable and bleeding edge release in the main post.
For us making the project chaotic, we're attempting to organize things by discussing changes, opening a GIT repo etc, but the problem lies with who has/wants access.
Not everyone wants to work in a team.

2. Naming:
Most people don't even remember the 'major milestone' from v.4.0 and v.5.0. It's better if you guys naming as
1st and 2nd: Follow the major HV version (0.6.9 -> 6.9)
3rd: new feature packs
4th: bug fix/dev build
It should work better as people will then understand if their version matches the latest HV patch.

I would rather use mrttao's system of [MajorMilestones.Features.Fixes.MinorFixes].
What I can do though, is include a tag in the main post with which version of HV we're currently compatible with.

3. A better way to explain what you have changed. Why do you guys need to ask the others every time something has changed?
Please remember, it's a program for players to use, not to confuse them.

On The Developer Side:
On the GIT I'm trying to be as descriptive as possible when updating but sometimes it's impossible to describe EXACTLY what's been changed, especially in larger updates.
As long as the commit isn't huge, you can see what's been changed in the diff.
Eventually I'd like to see comments in the code, ATM the code is as chaotic as we are.

On The User Side:
I agree but what would you suggest we do. We could announce only features being added and bugs being fixed and dumb some things down but that would leave dev's out of the loop (excl those with GIT access).


This post has been edited by GaryMcNabb: Jul 26 2012, 21:50

Sometimes this happen, I am currently using 5.3.3.1. It also happened in 5.2.2, in that it caused the scan/skill buttons not to show. I have unsuccessfully tried to find out why, but that part of the code makes my brain hurt (IMG:[invalid] style_emoticons/default/sad.gif)

Yea, i've had that happen too a few times... oddly enough, it seemed to not fix itself by just clicking the battle button in the menu, so it might be caused by a specific monster.. so next time it happens, please note down which enemies you are facing =)

Try version [github.com] 5.4.0.1.

It looks like an incomplete scan or something, but I can't be sure.
If it happens again, can you please enable "Show monster statistics on mouseover" and take a screenshot for me?

Sometimes this happen, I am currently using 5.3.3.1. It also happened in 5.2.2, in that it caused the scan/skill buttons not to show. I have unsuccessfully tried to find out why, but that part of the code makes my brain hurt (IMG:[invalid] style_emoticons/default/sad.gif)

there is an option called "Save skill types (elements) while used in battle (data updated on scan and outside of battle)"
I believe this is what you get when a monster was never scanned, but has had data collected on its attack type (which can be displayed)
As you can see, it doesn't know what the weaknesses, volnerabilities, class, or PL are. But it does know the attack type of that monster.

Also, I noticed that new monsters no longer display NEW, instead they are showing up as "0" or "-" for the class, I don't quite remember which (only saw a couple. I have enabled the feature to show monster PL but I have also updated to 5.4 at the same time). The rest as like your image, 0+ for PL, 0 and 0 for the weaknesses and resistances.
I am having a hard time finding more info because I very very rarely encounter an unscanned monster anymore.

PS. I think the NEW tag should be red to draw attention to it.

This post has been edited by mrttao: Jul 27 2012, 03:48

there is an option called "Save skill types (elements) while used in battle (data updated on scan and outside of battle)"

I believe this is what you get when a monster was never scanned, but has had data collected on its attack type (which can be displayed)

Also, I noticed that new monsters no longer display NEW, instead they are showing up as "0" or "-" for the class, I don't quite remember which (only saw a couple. I have enabled the feature to show monster PL but I have also updated to 5.4 at the same time). The rest as like your image, 0+ for PL, 0 and 0 for the weaknesses and resistances.
I am having a hard time finding more info because I very very rarely encounter an unscanned monster anymore.

That was fixed in version 5.4.0.1.
I had to change
if (mclass !== 0)
to
if (mclass !== "0")
Because mclass is a string for some reason :/

I was personally very happy with this update.
It introduced a couple of bugs due to previous lazy coding but they're easy enough to fix.
Thanks again.

My pleasure.
But some '==' and '!=' operators still have remained.
I missed them when I merged to 5.3.3.4.

My pleasure.
But some '==' and '!=' operators still have remained.
I missed them when I merged to 5.3.3.4.

Fixed it.
You should PM Ilirith for GIT access.

Fixed it.
You should PM Ilirith for GIT access.

Thanks.
I PMed Ilirith.

By the way, I found another bug related 10th monster.
In function collectRoundInfo, the number added after 'mkey_' is wrong.
'mkey_0' is correct, but now 'mkey_10'.

Thanks.
I PMed Ilirith.

By the way, I found another bug related 10th monster.
In function collectRoundInfo, the number added after 'mkey_' is wrong.
'mkey_0' is correct, but now 'mkey_10'.

I'm not sure what you mean sorry, but I'm sure you can fix it once Ilirith gets you access.

BTW, for anyone interested: I just uploaded 5.4.1 and it should boost Chrome users performance hard. It also fixes the Infinity HP/SP bug and if you disable HV logo, it stops it before it downloads the img file, giving you another performance boost.
Firefox users miss out because they haven't implemented 'beforeload' yet, sorry.

BTW, for anyone interested: I just uploaded 5.4.1 and it should boost Chrome users performance hard. It also fixes the Infinity HP/SP bug and if you disable HV logo, it stops it before it downloads the img file, giving you another performance boost.
Firefox users miss out because they haven't implemented 'beforeload' yet, sorry.

Tested you new version and it broke "Inpage equipment calculator".
Do you know why that may be?
Despite the fact that "Inpage equipment calculator" is no longer updated which is sad but it is still somewhat useable with H2Odk workaround.
I use Chrome btw.

This post has been edited by TheGreyPanther: Jul 27 2012, 18:22

Request adding to the .json file:

"exclude_matches": [ "http://hentaiverse.org/pages/showequip.php*" ]

HVSTAT doesn't have any feature's for individual equipment popups/pages, and the most recent 5.4.1 prevents the equipment calculator from working. I think its because of the change to load at document start.

Added exclude_matches and pushed the update. It'll be in 5.4.2.

Requests:
1. "Effect Expiring Warning: Absorb" removal.
2. "Alert when Absorb triggers" function addition.
3. "Alert when Overcharge is full" function addition.
3. Item tags function extension: a possibility to change/add equipment tags for multiple equipment at the same time.

It happened again


this is with 5.4.0.1, and even though I have modified it a bit (commented out all the replace statements (line 458-637)), I have not touched the part that get\set these values.

This post has been edited by H2Odk: Jul 28 2012, 00:26

Request add -> Track Sch Girl Trophy Drops.

3. "Alert when Overcharge is full" function addition.

now working

Tier-3 skill could not be selected with any hot key when tier-1 skill cooldown is finished. (before 5.2.2)

Chain 1 skill still overrides chain 3 when I played as a DWer.

Chain 1 skill still overrides chain 3 when I played as a DWer.

When pressing hot key first, chain 1 skill is selected if cooldown finished.
Then, pressing hot key again, chain 3 skill is selected if overcharge is enough.

Should select chain 3 skill first when it is available?

It happened again


this is with 5.4.0.1, and even though I have modified it a bit (commented out all the replace statements (line 458-637)), I have not touched the part that get\set these values.

This bug is an asshole but I'll see what I can do.

EDIT: Lame, I've fixed it but broke popup's somehow.

This post has been edited by GaryMcNabb: Jul 28 2012, 22:02