[X] My Assistant

I wonder if you guys can add a monster letters to numbers replacer from Tiap's HV Stat Slim to HV Stat somehow. (IMG:[invalid] style_emoticons/default/unsure.gif)

Yea, that should be easy to do.

Just did a test, injecting the Letter->number function from Tiaps into an active battle, worked fine.

gimmeh some minutes and i should be able to add it with a toggle in HVSTAT settings pane.

[Edit]

Done, packed it as a CRX as the others, and tested it out as well.

Just ignore the .PEM file, its only for packing scripts as CRX files.

 HVSTAT_5.2.7.zip ( 162.7k ) Number of downloads: 39


I forgot to increase the version number in the script itself, it will just show 5.2.6 in the HVSTAT window, but chrome will know that it is 5.2.7.


[More edits!]

Evil Scorpio requested that the hotkeys for Weapon skills were usable without showing the skill buttons.
So here is another update.

The only difference is that the Hotkey functionality of having enabled Scan/Skill buttons are now separate, so you can enable just the hotkeys or just the buttons if you wish.

Oh, and i also remembered to increment the version this time ( after evil reminded me >.> )

 HVSTAT_5.2.9.zip ( 162.83k ) Number of downloads: 59


This post has been edited by Ilirith: Jul 23 2012, 16:04

 HVSTAT_5.2.9.zip ( 162.83k ) Number of downloads: 59

Awesome! More karma to you.

This post has been edited by mrttao: Jul 23 2012, 22:48

Thanks again. Karma rain inc !

Edit : erf, need to wait some time to give more karma...

This post has been edited by Daodaodaidai: Jul 24 2012, 00:58

Got around to fixing some shit that was annoying me.

Added an icon, albeit a thrown together one.
Fixed Monster Popup code.
Partially rewrote showMonsterStats to include unscanned monster notification ([NEW] tag where scanned monster stats usually are), and added option to toggle showing monster class.
Rewrote StartBattleAlerts function so it works, runs slightly more efficiently, and isn't a nesting nightmare.
Partially rewrote Backup System to reduce code repetition.
Removed Save Custom Monster database option (Dead Link).
General code cleanup.

EDIT: BTW, it's a Chrome extension only.
TBH, there's alot of code that needs to be rewritten for readablilty, timing and performance.
Things like Hide HV logo are useless after the logo's already been loaded and needs to trigger before sub-resources are loaded, whereas things like Calculate Monster HP need to happen just after.
If anyone's interested, General code cleanup entailed logical rewrites like switches replacing if else chains, ternary's for small if elses and other boring shit along those lines.

EDIT 2: Helps if I include the attachment I guess.

EDIT 3: Updated, I forgot to link the backup buttons to the new function. Oops.

 HVSTAT_5.3.1.zip ( 171.4k ) Number of downloads: 43


This post has been edited by GaryMcNabb: Jul 25 2012, 00:01

Got around to fixing some shit that was annoying me.

Added an icon, albeit a thrown together one.
Fixed Monster Popup code.
Partially rewrote showMonsterStats to include unscanned monster notification ([NEW] tag where scanned monster stats usually are), and added option to toggle showing monster class.
Rewrote StartBattleAlerts function so it works, runs slightly more efficiently, and isn't a nesting nightmare.
Partially rewrote Backup System to reduce code repetition.
Removed Save Custom Monster database option (Dead Link).
General code cleanup.
 HVSTAT_5.3.1.zip ( 171.4k ) Number of downloads: 43

A question before I install this:
Does it contain the changes of the previous versions? (IMG:[invalid] style_emoticons/default/unsure.gif)

Thanks a lot for this. I managed to get even better (slightly) compression using PNGOUT rather then PNGCrush (via plugin for infranview) losslessly reducing them to 24.62% of original size.

After a ridiculous amount of time battling evil, evil syntax issues I got it working! (also learned a few things and figured out why things were broke)
And unless I am imagining things, it is significantly faster (so fast it just appears there now; IIRC it was slower before) in displaying the powerup images now (should be more pronounced the slower your bandwidth is (IMG:[invalid] style_emoticons/default/tongue.gif)).
It also had a minor issue where the image ID of both health and spirit gems as health gem which I also corrected.

 HVSTAT_5.2.5.zip ( 161.55k ) Number of downloads: 68

Just did a test, injecting the Letter->number function from Tiaps into an active battle, worked fine.
gimmeh some minutes and i should be able to add it with a toggle in HVSTAT settings pane.
I forgot to increase the version number in the script itself, it will just show 5.2.6 in the HVSTAT window, but chrome will know that it is 5.2.7.
[More edits!]
Evil Scorpio requested that the hotkeys for Weapon skills were usable without showing the skill buttons.
So here is another update.
The only difference is that the Hotkey functionality of having enabled Scan/Skill buttons are now separate, so you can enable just the hotkeys or just the buttons if you wish.
Oh, and i also remembered to increment the version this time ( after evil reminded me >.> )
 HVSTAT_5.2.9.zip ( 162.83k ) Number of downloads: 59

The embedding of the images into the add-on improved the speed significantly in version 5.2.5 and 5.2.9 added functionality that I don't wanna lose.
Anyway thank you for you effort in improving HV STAT! (IMG:[invalid] style_emoticons/default/wink.gif)

A question before I install this:
Does it contain the changes of the previous versions? (IMG:[invalid] style_emoticons/default/unsure.gif)

Yeah, I've tested it. It includes everything from previous versions (including 5.2.9).

Got around to fixing some shit that was annoying me.

Added an icon, albeit a thrown together one.
Fixed Monster Popup code.
Partially rewrote showMonsterStats to include unscanned monster notification ([NEW] tag where scanned monster stats usually are), and added option to toggle showing monster class.
Rewrote StartBattleAlerts function so it works, runs slightly more efficiently, and isn't a nesting nightmare.
Partially rewrote Backup System to reduce code repetition.
Removed Save Custom Monster database option (Dead Link).
General code cleanup.

EDIT: BTW, it's a Chrome extension only.
TBH, there's alot of code that needs to be rewritten for readablilty, timing and performance.
Things like Hide HV logo are useless after the logo's already been loaded and needs to trigger before sub-resources are loaded, whereas things like Calculate Monster HP need to happen just after.
If anyone's interested, General code cleanup entailed logical rewrites like switches replacing if else chains, ternary's for small if elses and other boring shit along those lines.

EDIT 2: Helps if I include the attachment I guess.

EDIT 3: Updated, I forgot to link the backup buttons to the new function. Oops.

 HVSTAT_5.3.1.zip ( 171.4k ) Number of downloads: 43

oh Thank you, Thank you!

I've had a hard time to get an overview over what the heck was what in the script, and your changes have made much of it, so much easier to keep track of.

By the way, if you have time at some point, why don't you drop by on IRC?

Should you guys have a separate thread so things can be properly updated and discussed then?

This post has been edited by varst: Jul 25 2012, 06:46

 HVSTAT_5.3.1.zip ( 171.4k ) Number of downloads: 43

I just examined the source and it does NOT include the changes I made in HVSTAT_5.2.5 and as such loads the powerup gems from the internet.
It is plausible that it then does not include the changes in the versions after 5.2.5

I will be going through it using diffuse to merge the patches and fixes as needed.

This post has been edited by mrttao: Jul 25 2012, 08:19

I just examined the source and it does NOT include the changes I made in HVSTAT_5.2.5 and as such loads the powerup gems from the internet.
It is plausible that it then does not include the changes in the versions after 5.2.5

I will be going through it using diffuse to merge the patches and fixes as needed.

Well, it definitely contains 5.2.9 changes.

Well, it definitely contains 5.2.9 changes.

Examining the code, it contains different code that does the same thing as a fix that was included in 5.2.9.
Hey, I love the improvements he made and I thank him for it. I am just gonna merge other fixes in that he is missing. Wish he said what version he modified though.

Current analysis (will be used for a merge when I am done)

CODE

Differences between 5.2.2 and 5.2.9; difference between those differences and 5.3.1
5.3.1 includes massive changes. Only changes that have occured between 5.2.2 to 5.2.9 will be discussed here.
line 2: version number, irrelevant
line 93-95: 5.2.2 to 5.2.9 If battle, call function for letters to numbers. 5.3.1 has different code that performs the same task.
line 306-350: 5.2.3.1 fixed address. 5.2.5 encoded the powerup gems & removed obsolete code. 5.3.1 includes the fix from 5.2.3.1 as well as the removal of obsolete code but is missing the improvement from 5.2.5
Line 922: 5.2.9 injected the code from HVSTAT slim for function showMonsterNumber(). 5.3.1 injected the same code between the same two functions.
Line 1014-1016: 5.2.2 to 5.2.9 Spirit total added by Ilirith. 5.3.1 contains same modification including the added by Ilirith note.

This post has been edited by mrttao: Jul 25 2012, 08:54

My bad, I think I might have sent out my working copy.
Is there a reason you encoded the images into the code rather than include them in the crx?

My bad, I think I might have sent out my working copy.

Not a problem. So what version did you base your work on? its very impressive work btw.

Is there a reason you encoded the images into the code rather than include them in the crx?

Nobody could figure out how to include them in the crx as filename.png
And no answer at the jquery forums [forum.jquery.com] https://forum.jquery.com/topic/including-an-image-from-file
I would switch it to pointing at png images at a heartbeat if I could.

The old method was to download them on the fly from HV website, which added noticable delay. I encoded them (after crushing them to 24.something% of original size) into it based on a technique from another poster here to mitigate that, and it noticeably improved performance.

The reason I went and checked the code in the first place is that I noticed the sudden recurrence of said delay.

Alright. I am done auditing the code.

CODE

Differences between 5.2.2 and 5.2.9; difference between those differences and 5.3.1
5.3.1 includes massive changes. Only changes that have occured between 5.2.2 to 5.2.9 will be discussed here.
line 2: version number, irrelevant
line 93-95: 5.2.2 to 5.2.9 If battle, call function for letters to numbers. 5.3.1 has different code that performs the same task (improved from existing code likely).
line 306-350: 5.2.3.1 fixed address. 5.2.5 encoded the powerup gems & removed obsolete code. 5.3.1 includes the fix from 5.2.3.1 as well as the removal of obsolete code but is missing the improvement from 5.2.5
Line 922: 5.2.9 injected the code from HVSTAT slim for function showMonsterNumber(). 5.3.1 injected the same code between the same two functions.
Line 1014-1016: 5.2.2 to 5.2.9 Spirit total added by Ilirith. 5.3.1 contains same modification including the added by Ilirith note.
Line 1032,1034-1035: 5.2.2 to 5.2.9 included a fix to proficiency sidebar. 5.3.1 includes those changes, and many more modifications.
Line 2046: 5.2.2 to 5.2.9 adds 30 lines of code to battle end stats. 5.3.1 includes those changes. Also fixes a syntax error 2 lines down of "return a" to "return a;"
Line 2856: 5.2.2 to 5.2.9 fixes some syntax in settings. Included in 5.3.1.
Line 2871: 5.2.2 to 5.2.9 adds settings by Ilirith, followed by the letters to numbers setting. Included in 5.3.1
Line 3018: 5.2.2 to 5.2.9 adds some settings. Found in 5.3.1 with different syntax. (improved from existing code likely)
Line 3180, 3307, 3438: 5.2.2 to 5.2.9 adds some settings by Ilirith. Found in 5.3.1
Line 3223, 3349, 3266 (I think I mixed up line number here), 4295, 4335, 4336, 4341: 5.2.2 to 5.2.9 adds some settings. Found in 5.3.1
Line 4171: 5.2.2 to 5.2.9 adds spirit total by Ilirith. Found in 5.3.1
Line 6342 to 6407 (not all of them, just select lines): 5.2.2 to 5.2.9 to scanbutton function. 5.3.1 includes all those additions, but rewrote syntax (on them and on all other data).
Line 7379: 5.2.2 to 5.2.9 Scan button modification. Found in 5.3.1

So, from a full line by line audit it seems the only change outright reversed in 5.3.1 is the powerup gems one. All the others are still there. Although some have had their syntax rewritten. (I did not dwell too much on those to see if it was done correctly)
I gotta say I am very impressed with the sheer amount of lines you rewrote. The undertaking must have been massive!

This post has been edited by mrttao: Jul 25 2012, 09:38

mrttao:
A plugin with images, Pony themed just cause.
 Pony.zip ( 17.88k ) Number of downloads: 29

 HVSTAT_5.3.2.zip ( 175.33k ) Number of downloads: 29

5.3.2: Reintegrated the internal encoding of the powerup gems into the plugin

mrttao:
A plugin with images, Pony themed just cause.
 Pony.zip ( 17.88k ) Number of downloads: 29

Thank you. I am gonna study it right now and see about doing something similar to the chrome extension.

mrttao:
A plugin with images, Pony themed just cause.
 Pony.zip ( 17.88k ) Number of downloads: 29

The syntax doesn't quite match, but I think I might have gotten it right...
Except I can't test because the json syntax is hating me. I managed to fix its issues with line 16 (it wanted a , on the end of line 15).
Then it was giving me a problem at Line 17 though is having a syntax error at column 19, which is the very end of it. I found that solution here [code.google.com] https://code.google.com/chrome/extensions/m...sible_resources

Going to test the extension now.
Not working... I am getting a headach. I think I am having a nesting issue. I need triple nested quotations and the method described in [en.wikipedia.org] https://en.wikipedia.org/wiki/Nested_quotation is not working.

This post has been edited by mrttao: Jul 25 2012, 10:26

HV_STAT.user.js

CODE

var d = "<img class='PowerupGemIcon' src='";
if (b.match(/health/i)) d += chrome.extension.getURL("healthpot.png")+ "' id='healthgem'>";
else if (b.match(/mana/i)) d += chrome.extension.getURL("manapot.png")+ "' id='managem'>";
else if (b.match(/spirit/i)) d += chrome.extension.getURL("spiritpot.png")+ "' id='healthgem'>";
else if (b.match(/mystic/i)) d += chrome.extension.getURL("channeling.png")+ "' id='channelgem'>";
c.innerHTML = d;

manifest.json

CODE

{
    "name": "HV Statistics, Tracking, and Analysis Tool (Chrome Edition)",
    "version": "5.3.3",
    "manifest_version": 2,
    "description": "Collects data, analyzes statistics, and enhances the interface of the HentaiVerse",
    "icons": {
        "128": "128.png",
        "16": "16.png",
        "48": "48.png"
    },
    "content_scripts": [ {
        "css": [ "jqueryui.css" ],
        "js": [ "jquery.min.js", "jquery-ui.min.js", "HV_STAT.user.js" ],
        "matches": [ "http://hentaiverse.org/*" ]
    } ],
    "web_accessible_resources": [
        "healthpot.png",
        "manapot.png",
        "spiritpot.png",
        "channeling.png"
    ]
}

This post has been edited by GaryMcNabb: Jul 25 2012, 10:33

json: Yea, thank you I had figured it out thanks to googling.

HV_STAT.user.js

CODE

var d = "<img class='PowerupGemIcon' src='";
if (b.match(/health/i)) d += chrome.extension.getURL("healthpot.png")+ "' id='healthgem'>";
else if (b.match(/mana/i)) d += chrome.extension.getURL("manapot.png")+ "' id='managem'>";
else if (b.match(/spirit/i)) d += chrome.extension.getURL("spiritpot.png")+ "' id='healthgem'>";
else if (b.match(/mystic/i)) d += chrome.extension.getURL("channeling.png")+ "' id='channelgem'>";
c.innerHTML = d;

I am pretty sure mis-nested some of those quotation marks...
I had in v5.2.5 removed the variable d outright because it was making a mess of things and the script was exploding...
Yet somehow I went and tested it and it fing works... why is it working?

I just tested the code:

CODE

function displayPowerupBox()
{
    var a = $("div.btp");
    var c = document.createElement("div");
    c.setAttribute("style", "position:absolute;top:7px;right:5px;background-color:#EFEEDC;width:30px;height:32px;border-style:double;border-width:2px;border-color:#555555;");
    var e = document.getElementById("ikey_p");
    if (e == null) c.innerHTML = "<span style='font-size:16px;font-weight:bold;font-family:arial,helvetica,sans-serif;text-align:center;line-height:32px;cursor:default'>P</span>";
    else
    {
        var b = e.getAttribute("onmouseover").match(/set_infopane_item\('.+?'/img)[0].substring(18);
        c.setAttribute("onmouseover", e.getAttribute("onmouseover"));
        c.setAttribute("onmouseout", e.getAttribute("onmouseout"));
        c.setAttribute("onclick", 'document.getElementById("ckey_items").onclick();document.getElementById("ikey_p").onclick();document.getElementById("ikey_p").onclick()');
        if (b.match(/health/i)) c.innerHTML = "<img class='PowerupGemIcon' src='chrome.extension.getURL("healthpot.png")' id='healthgem'>";
        else if (b.match(/mana/i)) c.innerHTML = "<img class='PowerupGemIcon' src='chrome.extension.getURL("manapot.png")' id='managem'>";
        else if (b.match(/spirit/i)) c.innerHTML = "<img class='PowerupGemIcon' src='chrome.extension.getURL("spiritpot.png")' id='spiritgem'>";
        else if (b.match(/mystic/i)) c.innerHTML = "<img class='PowerupGemIcon' src='chrome.extension.getURL("channeling.png")' id='channelgem'>";
    }
    a.after(c)
}

And it totally breaks the extension. (as I knew it would; alternating ' and " doesn't work for triple embedding. But it makes it easier to see)

Using instead:

CODE

if (b.match(/health/i)) c.innerHTML = "<img class='PowerupGemIcon' src=chrome.extension.getURL('healthpot.png') id='healthgem'>";
etc

CODE

if (b.match(/health/i)) c.innerHTML = "<img class='PowerupGemIcon' src='chrome.extension.getURL(healthpot.png)' id='healthgem'>";
etc

Or using the triple nesting rules from: [en.wikipedia.org] https://en.wikipedia.org/wiki/Nested_quotation

CODE

if (b.match(/health/i)) c.innerHTML = "<img class='PowerupGemIcon' src=/'chrome.extension.getURL(///'healthpot.png///')/' id='healthgem'>";
etc

has the extension work but the gems fail to show.

This post has been edited by mrttao: Jul 25 2012, 10:45

This works.

CODE

function displayPowerupBox(){
    var a = $("div.btp");
    var c = document.createElement("div");
    c.setAttribute("style", "position:absolute;top:7px;right:5px;background-color:#EFEEDC;width:30px;height:32px;border-style:double;border-width:2px;border-color:#555555;");
    var e = document.getElementById("ikey_p");
    if (e == null) c.innerHTML = "<span style='font-size:16px;font-weight:bold;font-family:arial,helvetica,sans-serif;text-align:center;line-height:32px;cursor:default'>P</span>";
    else{
        var b = e.getAttribute("onmouseover").match(/set_infopane_item\('.+?'/img)[0].substring(18);
        c.setAttribute("onmouseover", e.getAttribute("onmouseover"));
        c.setAttribute("onmouseout", e.getAttribute("onmouseout"));
        c.setAttribute("onclick", 'document.getElementById("ckey_items").onclick();document.getElementById("ikey_p").onclick();document.getElementById("ikey_p").onclick()');
        if (b.match(/health/i)) c.innerHTML = "<img class='PowerupGemIcon' src='"+ chrome.extension.getURL("healthpot.png")+ "' id='healthgem'>";
        else if (b.match(/mana/i)) c.innerHTML = "<img class='PowerupGemIcon' src='"+chrome.extension.getURL("manapot.png")+ "' id='managem'>";
        else if (b.match(/spirit/i)) c.innerHTML = "<img class='PowerupGemIcon' src='"+chrome.extension.getURL("spiritpot.png")+"' id='spiritgem'>";
        else if (b.match(/mystic/i)) c.innerHTML = "<img class='PowerupGemIcon' src='"+chrome.extension.getURL("channeling.png")+"' id='channelgem'>";
    }
    a.after(c);
}

Should you guys have a separate thread so things can be properly updated and discussed then?

Might not be a bad idea, that way this thread can stay "clean" from the back and forth blabbering :3