[X] My Assistant

any news on the script? (IMG:[invalid] style_emoticons/default/biggrin.gif)

The new version 2.2.0 is already on GitHub but I found out that the update is not being accepted by openuserjs.org, where this script is hosted for download and automatic update. When I tried to manually update it there, it gives me error 400 "@grant with value of GM.download is not valid or supported". I am not sure why this is happening, because earlier versions never had a problem with this @grant GM.download. I have not decided what to do, but you can grab version 2.2.0 from GitHub if you want before I do something with openuserjs.org in the next a few hours.

Maintenance update: Mayriad's EH Master Script v2.2.0

This script has not been updated for almost two years and this update does all the catch-up required up to today. It has been mostly ready for a while since the recent search engine update, and I waited until the site update is final and fully deployed. It does not add any new feature, but still took me quite some time. A lot of design fixes have been removed because they have been implemented by the site.

Changelog

Scientific dark theme:

- Updated the scientific styles to use the latest style sheet.

Scientific light theme:

- Updated the scientific styles to use the latest style sheet.

Design fixes:

- Redesigned the fix that extends the search result message and reports how many results are shown on the page.

- Redesigned the fix for the "no unfiltered results" table.

- Removed the fix for the indistinctive colours used for visited titles, because this is no longer possible for userscripts to do. Browsers now block the relevant CSS selector to prevent history sniffing in general.

- Removed the fix for the lack of space at the beginning of the popular list.

- Removed the fix for the search result wording for page range due to the new search engine.

- Removed the fix for the position of ponies. This fix was already disabled before this update, because it is not straightforward and also not really needed.

- Removed the fix for the missing border at the top-right corner of each user stat bar graph, because the site has fixed this.

- Removed the fix that creates the new navigation bar for some pages, because the site has fixed this.

- Removed the fix for the inconsistent height of the upload button, because the site has redesigned it.

- Removed the fix for the spacing between username and PM icon in the expunged log. This fix was already disabled before this update, because the site redesigned it earlier.

- Removed the fix for dark theme arrow colours in the gallery list page selector, which has been removed, and moved the fix for the bounty list to the scientific dark theme feature.

Subjective fixes:

- Revised the fix for the width of the "tag" button in gallery view.

- Removed the fix that adjusts input elements everywhere, as it is less necessary and more difficult to maintain now.

- Removed a few lines of redundant CSS.

Jump to top/bottom buttons:

- Redesigned the slide-in rectangular buttons very slightly.

Additional gallery filters:

- Redesigned the filter result message and the "no result" view from this feature, partly to work with the new UI.

Automated gallery downloads:

- Set this feature to disabled when a gallery list does not have any gallery to download after filters.

- Redesigned the page download button to work with the new UI and set it to disabled when the control panel is open.

- Revised the page download protection sub-feature to work with the new UI.

- Changed two lines to use the new page-less navigation in page download mode.

Vigilante thread links:

- Updated the tag namespacing and comment cleanup links to use the new threads.

- Fixed the vertical position of the tag loading GIF to keep it inside the tagging panel when this feature is active.

GUI control panel:

- Redesigned the control buttons to work with the new UI. The buttons added by this script and the display mode selector have been made vertically symmetrical. Some browsers may however randomly create subpixel inaccuracy that vertically misaligns the buttons by like 0.1 px.

- Redesigned the control panel slightly to better match the size of gallery lists in non-thumbnail display modes.

- Changed a bit of wording.

- Removed the control panel from the favourite list due to a lack of space for the buttons, and also from cases when there is no actual gallery list.

General:

- Updated the upload management URLs.

- Tidied up the code a little bit.

Patch update: Mayriad's EH Master Script v2.2.1

The last update to version 2.2.0 was blocked by openuserjs.org, where this script is hosted for download and automatic update, because it gave error 400 "@grant with value of GM.download is not valid or supported" and at least another for GM.info when I tested. I am not sure why this is happening now, because earlier versions never had a problem with these two @grants. However, it seems the script runs fine without them, and I have removed them so that the script update can be accepted and pushed to users. I cannot remember why I added the ones using GM.* dot notation years ago.

Changelog

General:

- Removed all @grants that use the GM.* dot notation, and also GM_info from the userscript metadata block.

[github.com] This commit makes the script not work at all for me (Firefox 107.0, Violentmonkey)
And [github.com] this breaks it too as it doesn't seem to return undefined with Violentmonkey anymore. Easily fixed for myself but just a heads up.

Edit: also unicode characters are fucked up when downloading archives with violentmonkey, works fine on tampermonkey so i assume this is not a problem with the script.

This post has been edited by 255555555: Nov 19 2022, 21:57

Is it possible for top/bottom buttons size to be configurable/fixed?
They seem really HUGE in high resolution.

[github.com] This commit makes the script not work at all for me (Firefox 107.0, Violentmonkey)
And [github.com] this breaks it too as it doesn't seem to return undefined with Violentmonkey anymore. Easily fixed for myself but just a heads up.

Hmph, I suspected that I added GM.* years ago for Violentmonkey, because my code comments mentioned it a bit. Thank you for the quick report. As I said in the v2.2.1 update above your post, that commit was effectively intentionally breaking it on Violentmonkey because otherwise openuserjs.org will not accept it. They are indeed wrong then.

Before I did v2.2.1, I considered investigating a bit more and moving the script to Greasy/Sleazy Fork, but that can be tricky and I prioritised getting the update out first. A seamless transition that requires no action from users can be tricky because I need to change the script auto-update source URL on openuserjs.org first, and they may not allow me to set it to another website. I do need to move it now and basically roll back to v2.2.0, so you can expect a fix (for others) tomorrow. In the worst case I will just set it up on Greasy Fork without linking the two.

Is it possible for top/bottom buttons size to be configurable/fixed?
They seem really HUGE in high resolution.

Do they? They have a fixed relative height (and width) that is basically 10% of the height of your screen. I intentionally made them a bit large and easy to click, and people find them fine. I don't think I will adjust their size or add an option for it, but you can search "#jumpToTopButton, #jumpToBottomButton { height: 10vh; width: 10v" in the code and reduce the size (down from 10vh or 10vw) yourself depending on whether you use the rectangular or circular buttons.

This post has been edited by Mayriad: Nov 19 2022, 22:44

Does just using github instead of any of the userscript sites not work?

Does just using github instead of any of the userscript sites not work?

I think it should work, but changing it to GitHub now is probably not any easier than changing it to Sleazy Fork. Also, I want to see a download count, so I would put the download and update links on a userscript website that can easily count that.

Edit: Ughhh Sleazy Fork still looks a bit annoying with all those comments, which is one of the reasons I put it on openuserjs in 2019. openuserjs has a forum that is rather quiet, but I might ask there and wait for a reply from them first, or maybe I can just add back some but not all @grants that will allow the script to work with Violentmonkey.

This post has been edited by Mayriad: Nov 19 2022, 23:24

I don't think I will adjust their size or add an option for it, but you can search "#jumpToTopButton, #jumpToBottomButton { height: 10vh; width: 10v" in the code and reduce the size (down from 10vh or 10vw) yourself depending on whether you use the rectangular or circular buttons.

It works for me, thank you (IMG:[invalid] style_emoticons/default/biggrin.gif) .

The configure master button isn't showing up for me, trying to find out why

edit: works normally on google chrome, but not on opera gx

This post has been edited by Pamlau: Nov 20 2022, 00:27

doesn't work for me on opera

nice to see it back to work! Thank you Mayriad.

Patch update: Mayriad's EH Master Script v2.2.2

I removed a bit too many @grants in the v2.2.1 update to make openuserjs.org accept v2.2.0, and that stopped the script from functioning on at least Violentmonkey and Opera. I have added back those three @grants to allow the script to work again on those platforms.

Changelog

Automated gallery downloads:

- Edited a few words in the error messages about GM.download().

General:

- Added back three @grants to the userscript metadata block that were removed earlier and broke Violentmonkey and Opera support.

Thanks, works out of the box again.
Although GM_download works just fine for me with Violentmonkey, apart from, as mentioned, unicode characters being fucked.

the Configure button disappears if you have enabled the Jump/Seek integration from the EH Page Scrobbler userscrip, not sure if something can be done about that.

Disabled
(IMG:[i.imgur.com] https://i.imgur.com/onS0Byx.png)

Enabled
(IMG:[i.imgur.com] https://i.imgur.com/k02Kmml.png)

An file download failed, because the extension of this file is not in the whitelist for GM.download() in Tampermonkey advanced settings. This means you have either not added .torrent to this list or removed .zip from it. Please ensure both extensions are whitelisted in the "downloads beta" section in Tampermonkey advanced settings.

edit:

OK, I see the problem. the script enabled torrent download dy default, but .torrent is not in the whilelist. I just disable it, then every download become "The download cannot be initiated for some unknown reason."

This post has been edited by ace_amuro: Nov 21 2022, 12:21

The download cannot be initiated for some unknown reason. An error log will be automatically downloaded, which can be submitted to the author in a bug report.

the bug report:

Function:
useAutomatedDownloads

URL:
https://e-hentai.org/

HTML:
<html><head></head><body>undefined</body></html>

IDM then popped a download window, so the script works.

now i just comment out from line 4103 to line 4116.

This post has been edited by ace_amuro: Nov 21 2022, 12:48

I managed to avoid moving the script to Sleazy Fork, for now.

edit: works normally on google chrome, but not on opera gx

doesn't work for me on opera

Opera support should be fixed now. The incompatibility was also caused by the removal of GM.* grants, which is actually a bit surprising. The automated download feature requires // @grant GM.download and that is blocked by openuserjs.org, so it will not work at the moment. It will take some time to sort it out, so for now you can manually add "// @grant GM.download" next to other @grant lines at the beginning of the code. This should be all it takes to make it work again.

Thanks, works out of the box again.
Although GM_download works just fine for me with Violentmonkey, apart from, as mentioned, unicode characters being fucked.

Ah, I think you mean Violentmonkey doing blob downloads using GM.download(); I was a bit puzzled when you mentioned it last time, because the official download method that uses browser API is (still) not supported by Violentmonkey. I had reasons not to support blob download, like the lack of error handling, memory usage and slower speed, and I do not recommend it. Unicode characters should not necessarily have a problem on Violentmonkey, though. I just tested Violentmonkey on Vivaldi and Unicode characters are normal for me. Maybe you should try a different browser or change some OS settings.

the Configure button disappears if you have enabled the Jump/Seek integration from the EH Page Scrobbler userscrip, not sure if something can be done about that.

Nothing can be done at the moment, becasue I cannot make my script compatible with whatever EH scripts users also want to use. The only option is writing a similar functionality for my script to remove the need to use another one.

where's the "Tampermonkey advanced settings" ?

Please read the user manual, especially [github.com] the third paragraph here. It is not like I want to make it complicated and write a manual, but Tampermonkey requires those manual steps.

The download cannot be initiated for some unknown reason. An error log will be automatically downloaded, which can be submitted to the author in a bug report.

now this, so where's the error log ?

It was downloaded, so it should be in the download location you set for your browser. If it is not there then the download was blocked for some reason.

Edit:

OK, I see the problem. the script enabled torrent download dy default, but .torrent is not in the whilelist. I just disable it, then every download become "The download cannot be initiated for some unknown reason."

IDM then popped a download window, so the script works.

"Show error notification popups" was disabled, but it still shows the "unknown reason" error popup

Ah, I see you rewrote your posts. It seems you have done the setup required and it is working now. Regarding the "unknown reason" error popup, it is always shown because it is not supposed to happen and the error log can be important. In your case, though, the error log is empty and I think it might be caused by the use of IDM, because I never intended to support download managers and it is just difficult. If you always get this error then it is most likely caused by IDM.

now i just comment out from line 4103 to line 4116.

Yeah just customise the code if you can. I am glad it is working for you.

This post has been edited by Mayriad: Nov 21 2022, 13:53

>Ah, I think you mean Violentmonkey doing blob downloads using GM.download();
okay that makes sense, i have zero experience with userscripts so i wasn't sure. I will keep it disabled until violentmonkey devs decide to support it properly.

Just tried this out for the first time today and it's a huge improvement, but I have a problem that isn't with the script itself and I wasn't sure where to ask.

I have an issue with MPV where the images get scaled properly but are not vertically centered when changing pages. Aside from the first image, images are off by a couple pixels down the page. Going to fullscreen or resizing the window makes no difference. I have the image scaling option in e-hentai settings currently set to 0, but I had it set to fit my screen on fullscreen so I never noticed this as a problem before using this script. The script's fit to screen option for MPV is great, but because off the offset MPV is less convenient with it.



I'm on Firefox and have tried disabling all extensions. Pretty sure this isn't caused by userscripts but I'm using Monsterbation, HV Utils, and Master Script.