 |
 |
 |
[Script] Monsterbation 1.4.1.2, A comprehensive hovering script for HentaiVerse and ISK. Including CrunkJuice 1.3.0, an out-of-battle script |
|
Oct 9 2018, 10:23
|
sickentide
Group: Catgirl Camarilla
Posts: 1,355
Joined: 31-August 10

|
QUOTE((Cheater) KamuiSeph @ Oct 8 2018, 19:27)  Is there a settings menu for this script? Or do I have to edit stuff directly?
unless something big comes up, a config menu should be among the next set of features to add, but i'm somewhat busy with other matters at present. for now, edit the settings and key bindings sections in tampermonkey QUOTE((Cheater) KamuiSeph @ Oct 8 2018, 19:27)  Can I turn the auto-hit off?
you can turn off hover permanently by setting hoverAction = false or turn it on manually each round by setting startRoundWithHover = false. to toggle it, bind ToggleHover to any key, the default is Z
|
|
|
|
 |
|
Oct 9 2018, 11:23
|
KamuiSeph
Group: Gold Star Club
Posts: 2,076
Joined: 29-August 08

|
QUOTE(sickentide @ Oct 9 2018, 17:23)  unless something big comes up, a config menu should be among the next set of features to add, but i'm somewhat busy with other matters at present. for now, edit the settings and key bindings sections in tampermonkey you can turn off hover permanently by setting hoverAction = false or turn it on manually each round by setting startRoundWithHover = false. to toggle it, bind ToggleHover to any key, the default is Z
Thank you!! Super helpful! And I look forward to the config menu :3
|
|
|
Oct 9 2018, 11:48
|
tox01
Group: Gold Star Club
Posts: 567
Joined: 16-April 09

|
sickentide, function Observe should include ProcessLog() in battle end check part. Otherwise last turn's damage data is not counted.
Thank you
|
|
|
Oct 9 2018, 17:08
|
sickentide
Group: Catgirl Camarilla
Posts: 1,355
Joined: 31-August 10

|
QUOTE(tox01 @ Oct 9 2018, 11:48)  function Observe should include ProcessLog() in battle end check part. Otherwise last turn's damage data is not counted.
right, fixed. the original use of that function was only to track cooldowns, which wasn't needed at end of battle
|
|
|
Oct 27 2018, 09:14
|
BlueWaterSplash
Group: Members
Posts: 3,421
Joined: 15-March 11

|
Up until now I've been playing with the mouseEngage setting on so that I can hold the mouse button to attack instead of hovering. But now that my character is much stronger and faster, pure hovering is starting to become more convenient.
Is there a way to toggle the hovering behavior between pure hovering and using mouseEngage? I tried various combinations and they don't seem to work. I also tried pressing Z for ToggleHover but that likewise doesn't seem to work for this purpose.
|
|
|
Oct 27 2018, 12:24
|
tox01
Group: Gold Star Club
Posts: 567
Joined: 16-April 09

|
Request: Sort "Used: " (Example: Used: Mana Draught: 24, Protection: 10 ...) line, which appears in the combat log at the end of battle by alphabet [inside function ShowUsage].
Thank you.
|
|
|
|
 |
|
Oct 28 2018, 02:09
|
sickentide
Group: Catgirl Camarilla
Posts: 1,355
Joined: 31-August 10

|
QUOTE(BlueWaterSplash @ Oct 27 2018, 09:14)  Up until now I've been playing with the mouseEngage setting on so that I can hold the mouse button to attack instead of hovering. But now that my character is much stronger and faster, pure hovering is starting to become more convenient.
Is there a way to toggle the hovering behavior between pure hovering and using mouseEngage? I tried various combinations and they don't seem to work. I also tried pressing Z for ToggleHover but that likewise doesn't seem to work for this purpose.
i should give HoverAction the option to change the hover action permanently. for now, try this: CODE hoverAction = false, // ... Bind(KEY_Q, HoverAction(Nothing, true)); Bind(KEY_W, HoverAction(false, true)); and around line 350, where it says CODE function handleKeyup(e) { shiftHeld = e.shiftKey; ctrlHeld = e.ctrlKey; altHeld = e.altKey; hoverAction = defaultAction; remove or comment out the line "hoverAction = defaultAction;" now you can toggle between full hover and mouse engage with the Q and W keys QUOTE(tox01 @ Oct 27 2018, 12:24)  Request: Sort "Used: " (Example: Used: Mana Draught: 24, Protection: 10 ...) line, which appears in the combat log at the end of battle by alphabet [inside function ShowUsage].
Thank you.
making the usage log smarter (counting hits and misses etc.) is on the roadmap, though i would prefer to sort them by category rather than alphabetically
|
|
|
|
 |
|
Oct 28 2018, 02:50
|
BlueWaterSplash
Group: Members
Posts: 3,421
Joined: 15-March 11

|
Thanks, I'm guessing something similar to change the noPopup setting in realtime would also work? Because I think noPopup = false, goes better with the mouseEngage style. While noPopup = true goes better with pure hovering.
For now I'm playing with pure hovering to see if I can get used to it this time. I think pure hovering goes better with 1H spread attack style, while mouseEngage goes better with 1H one-by-one targeting style (safer in IW and Grindfest).
|
|
|
|
 |
|
Oct 28 2018, 03:19
|
sickentide
Group: Catgirl Camarilla
Posts: 1,355
Joined: 31-August 10

|
QUOTE(BlueWaterSplash @ Oct 28 2018, 02:50)  Thanks, I'm guessing something similar to change the noPopup setting in realtime would also work? Because I think noPopup = false, goes better with the mouseEngage style. While noPopup = true goes better with pure hovering.
for this you can modify line 453 like so: CODE document.addEventListener('mouseup', function() { hoverAction = defaultAction; noPopup = true; }, true); } and line 869 like so: CODE function MouseEngage(e) { noPopup = false; if ( e.which == 1 ) hoverAction = clickLeft; else if ( e.which == 2 ) hoverAction = clickMiddle; else if ( e.which == 3 ) hoverAction = clickRight; }
|
|
|
|
 |
|
Oct 30 2018, 09:02
|
BlueWaterSplash
Group: Members
Posts: 3,421
Joined: 15-March 11

|
Now that I've practiced a bit more I think noPopup = true can be fine with mouseEngage, rather what that style could benefit from instead is a new setting to disable the hover at the beginning of each new round until the mouse is clicked and held again. That preserves one of the additional benefits of the mouseEngage style, which is precise control over your actions.
|
|
|
|
 |
|
Oct 30 2018, 16:37
|
sickentide
Group: Catgirl Camarilla
Posts: 1,355
Joined: 31-August 10

|
QUOTE(BlueWaterSplash @ Oct 30 2018, 09:02)  Now that I've practiced a bit more I think noPopup = true can be fine with mouseEngage, rather what that style could benefit from instead is a new setting to disable the hover at the beginning of each new round until the mouse is clicked and held again. That preserves one of the additional benefits of the mouseEngage style, which is precise control over your actions.
there is such a setting! try clearRound = true
|
|
|
|
 |
|
Oct 31 2018, 08:49
|
BlueWaterSplash
Group: Members
Posts: 3,421
Joined: 15-March 11

|
It works perfectly, thanks. And it's also convenient that it doesn't do anything with pure hovering on, it only affects mouseEngage for my purposes. I had to download the new version script to use it, I was still on 1.2.2.4
I had no idea about the channeling ruling, but I just added channeling.png to my alerts and it achieves almost the same for my purposes. Actually it's better for me this way since I'm using melee, not mage.
I noticed the right/middle mouse button bindings work better in this version. The inputs used to get swallowed up in pure hovering but they work now. I might be encountering some kind of bug with this new version. In random encounters I keep seeing those old pink monsters and the recognized monsters have wrong data (species etc). If I reload the encounter in a new window it fixes itself.
|
|
|
|
 |
|
Oct 31 2018, 09:17
|
sickentide
Group: Catgirl Camarilla
Posts: 1,355
Joined: 31-August 10

|
QUOTE(BlueWaterSplash @ Oct 31 2018, 08:49)  In random encounters I keep seeing those old pink monsters and the recognized monsters have wrong data (species etc).
this can happen when you enter battle in one browser and exit it in another. you can fix it by entering and exiting battle in the affected browser. i guess i could have it delete monster data whenever you're out of battle, but usage of more than one browser (if that is even the cause here and this isn't a new, undocumented bug) is a rather exotic case
|
|
|
|
 |
|
Nov 4 2018, 12:41
|
balengooo
Group: Gold Star Club
Posts: 361
Joined: 14-April 13

|
Hello, since when I updated the script I have the problem that tracking doesn't reset after a Random Encounter and values are added to the next ones. I've managed to inspect localstorage trough console and found that all the data of active logs (HVtimelog,HVvitals,HVtrackdrops,HVcombatlog) are preserved after the battle. If I delete the data manually, the next RE everything is ok. I don't understand much about scripting, but I searched into the script and IMHO it looks like the calls "localStorage.removeItem" don't execute, not only the two with option (deleteDropLog, deleteCombatLog). I tried to debug but it's far above my ability and don't even found where to read the code being executed, but if there is something I can do to help point out the problem, please ask.
These are the setting I use: trackDrops = true, detailedDroplog = true, detailedCrystlog = true, equipmentCutoff = 4, selectLog = false, terseLog = false, trackProficiency = true, proficiencySidebar = true, profbarInMainpane = false, deleteDropLog = 2, trackSpeed = true, trackDamage = true, trackUsage = true, deleteCombatLog = 2, consoleLog = false, showRound = true,
Thank you for your work
|
|
|
|
 |
|
Nov 4 2018, 13:05
|
sickentide
Group: Catgirl Camarilla
Posts: 1,355
Joined: 31-August 10

|
QUOTE(balengooo @ Nov 4 2018, 12:41)  I tried to debug but it's far above my ability and don't even found where to read the code being executed, but if there is something I can do to help point out the problem, please ask.
i suspect that something crashes one of the functions called at the end of battle before the script gets to the local storage cleanup. i tested the settings you posted and they do not seem to be the issue, so my questions would be: 1. which browser are you using, and have you tried the latest versions of chrome or firefox (the officially supported browsers)? 2. when you updated the script, did you make sure that any newly introduced settings are set to a valid value?
|
|
|
|
 |
|
Nov 4 2018, 13:29
|
balengooo
Group: Gold Star Club
Posts: 361
Joined: 14-April 13

|
I think you already pointed out the problem: I run an olf version of firefox (56), because I use some plugins that are not compatible with the new ones..... (about point 2, yes, I usually take the new version of the script and update it comparing text and changing only the setting I want to keep).
So I have to disable tracking?
(As soon as possible I'm going to try to access HentaiVerse on another PC with FF up to date, to check if that solves the problem)
This post has been edited by balengooo: Nov 4 2018, 13:38
|
|
|
|
 |
|
Nov 4 2018, 13:54
|
sickentide
Group: Catgirl Camarilla
Posts: 1,355
Joined: 31-August 10

|
QUOTE(balengooo @ Nov 4 2018, 13:29)  So I have to disable tracking?
the likeliest culprits are the ShowDrops, ShowUsage and ShowDamage functions, so it may help to fiddle with the related settings, or try commenting out each function around line 543 and see if that fixes anything
|
|
|
Nov 4 2018, 14:23
|
balengooo
Group: Gold Star Club
Posts: 361
Joined: 14-April 13

|
ok, I'll make some attempts. I'll take some time because I'll have to wait for new RE....
When I'll have news I'll post.
thanks
|
|
|
Nov 4 2018, 17:37
|
balengooo
Group: Gold Star Club
Posts: 361
Joined: 14-April 13

|
The problem is into ShowDamage. If it is disabled the localsotrage is cleaned. The same if is set trackDamage = false.
I'll try to look into that function. OK, It's too complicated for me. I'll keep that function disabled. No big problem.
Thanks
This post has been edited by balengooo: Nov 4 2018, 18:08
|
|
|
|
 |
|
Nov 4 2018, 19:15
|
sickentide
Group: Catgirl Camarilla
Posts: 1,355
Joined: 31-August 10

|
QUOTE(balengooo @ Nov 4 2018, 17:37)  The problem is into ShowDamage.
all right, thanks for helping me pinpoint the cause. now to figure out which part of the function breaks compatibility. does the console give any useful error messages? could be declaring and invoking functions in one instruction. if you don't mind, i'd like you to take lines 1528-1529: CODE (combatlog.ptaken[type] + combatlog.mtaken[type]).toLocaleString() : '') + '</td>' : ''); }, total = { 'pdealt': Column('pdealt', ''), 'mdealt': Column('mdealt', ''), and replace them with: CODE (combatlog.ptaken[type] + combatlog.mtaken[type]).toLocaleString() : '') + '</td>' : ''); }; var total = { 'pdealt': Column('pdealt', ''), 'mdealt': Column('mdealt', ''),
|
|
|
1 User(s) are reading this topic (1 Guests and 0 Anonymous Users)
0 Members:
|
 |
 |
 |
|