[X] My Assistant

Why is our own rating color in a gallery not appearing in the favorite page? Is that a mistake or the way they want it to be? The rating color in the gallery only appears in the front page but not in my favorite page..

This post has been edited by Nightshu: Mar 29 2016, 21:39

The one between the "Search Favorites"/ "Clear" buttons and the page select bar (the "Showing 1-50 of 1,001")

This should be fixed now.

Why is our own rating color in a gallery not appearing in the favorite page? Is that a mistake or the way they want it to be? The rating color in the gallery only appears in the front page but not in my favorite page..

Should be everywhere. And does, as far as I can tell.

Yep, looks like it. Thx

It looks like another bug appeared for me: Galleries I favorited (and were uploaded) within the last two days or so show up in my Favorites list at the very end instead of the front when I sort them by the time I favorited them. Does anyone else have the same problem or is this intentional? Until a few days ago, new favorites showed up in front of the list, not at the end.

^ yep i can replicate that

it is yet another 1970-01-01T00:00Z bug.

It looks like another bug appeared for me: Galleries I favorited (and were uploaded) within the last two days or so show up in my Favorites list at the very end instead of the front when I sort them by the time I favorited them. Does anyone else have the same problem or is this intentional? Until a few days ago, new favorites showed up in front of the list, not at the end.

^ yep i can replicate that

Turns out this could happen if you rated the gallery before favoriting it, should be fixed now.

Turns out this could happen if you rated the gallery before favoriting it, should be fixed now.

Thanks for fixing it. (IMG:[invalid] style_emoticons/default/smile.gif)

nice

nice

The rating colour of the gallery is not appearing in the favorites page if you have it displayed as "Thumbnails". In "Show list" it is working fine.

The rating colour of the gallery is not appearing in the favorites page if you have it displayed as "Thumbnails". In "Show list" it is working fine.

Fixed.

I noticed when 're-visiting' an older gallery if I decided to change my vote the rating color of the gallery of course changes and stays with the new rating selection. But is this like before where it would actually have no real effect or are we now able to truly change our vote and give a more favorable rating to a gallery ?

I noticed when 're-visiting' an older gallery if I decided to change my vote the rating color of the gallery of course changes and stays with the new rating selection. But is this like before where it would actually have no real effect or are we now able to truly change our vote and give a more favorable rating to a gallery ?

You should be able to change your rating at any time.

Have the favorites always displayed 50 results by page?
I thought it was 25 like normal gallery browsing.
Maybe it's just me feeling it's unusually high vertically (IMG:[invalid] style_emoticons/default/unsure.gif)

edit @72119194545: No, I have 25 on normal galleries display, and 50 on favorites.And I can't try to change the value to see if it change both, neither or only one, since I don't have those perks in the first place (IMG:[invalid] style_emoticons/default/tongue.gif)

Did more testing.

While the favorites section isn't clearly mentioned on "Search Result Count", there is a bit about "torrent search pages".
If this mean the section loaded through "Torrents" between "Front Page" and "Favorites" at the top of the screen, then here too, I see 50 results when I think I should have 25.

Indeed, torrents and favs go 50-50-100-200 respectively (search results still give 25-50-100-200 as intended though). Guess that's a feature if you don't have any perk in that line yet. (IMG:[invalid] style_emoticons/default/laugh.gif)

Is this indeed not a bug, but a feature after all?

Lots of new development (IMG:[invalid] style_emoticons/default/smile.gif)

This forum is awesome.

Can't wait to see what it's like in 2020 (IMG:[invalid] style_emoticons/default/biggrin.gif).

nice fixing (IMG:[invalid] style_emoticons/default/biggrin.gif)

Did more testing.

While the favorites section isn't clearly mentioned on "Search Result Count", there is a bit about "torrent search pages".
If this mean the section loaded through "Torrents" between "Front Page" and "Favorites" at the top of the screen, then here too, I see 50 results when I think I should have 25.
Indeed, torrents and favs go 50-50-100-200 respectively (search results still give 25-50-100-200 as intended though). Guess that's a feature if you don't have any perk in that line yet. (IMG:[invalid] style_emoticons/default/laugh.gif)
Is this indeed not a bug, but a feature after all?

It is something I decided to keep, but it's really a remnant from a change I decided to revert. Originally I was planning on making it so that all list-mode results had twice as many results as all thumb-mode results, but it turns out that doing that for the search/front page had an non-fixable complication with converting the page number when you switch mode. (When going from list to thumb mode, the site wouldn't be able to determine whether you wanted page * 2 or page * 2 + 1).

There is some edge case in the template for the "> Add to Favorites" button. It works in 95% percent of my favorites as expected but just a handful galleries display it wrong.

For example, these two galleries are by the same artist, are in the same category, i rated them to the same value (5 starts) and i favourited them to the same favourite marker (black diamond). Yet:

The first gallery displays the <div id="fav" ...> showing the black diamond.

Whilst the second gallery displays nothing inside the <div id="fav" ...> and displays the "> Add to Favorites" div instead.

I have tried favouriting the second gallery again (without changing the favourite category), and it did display the <div id="fav" ...> constructed by javascript but once i refreshed the page the <div id="fav" ...> was empty again.

I have destroyed my browser cache and managed to replicate this with a clean cache.

I can find both galleries when i search my favourites.

I suspect an edge case in the display template, or maybe a stuck Varnish cache.

There is some edge case in the template for the "> Add to Favorites" button. It works in 95% percent of my favorites as expected but just a handful galleries display it wrong.

For example, these two galleries are by the same artist, are in the same category, i rated them to the same value (5 starts) and i favourited them to the same favourite marker (black diamond). Yet:

The first gallery displays the <div id="fav" ...> showing the black diamond.

Whilst the second gallery displays nothing inside the <div id="fav" ...> and displays the "> Add to Favorites" div instead.

I have tried favouriting the second gallery again (without changing the favourite category), and it did display the <div id="fav" ...> constructed by javascript but once i refreshed the page the <div id="fav" ...> was empty again.

I have destroyed my browser cache and managed to replicate this with a clean cache.

The only thing I can think of is that there was a replication delay, and you managed to reload the gallery page before the change was propagated, which could make it re-cache a stale record. I put it some extra code to make it rebuild the cached records from the main database instead of just invalidating it, which should prevent that.

Edit: There does seem to be some other caching weirdness with those particular galleries, I'll have to take a closer look at it.

Edit 2: There was another caching issue specific to the gallery page and the black favorite category. Should be fixed now. You can re-rate or re-favorite the gallery to force a cache refresh if you want to test it.

The only thing I can think of is that there was a replication delay, and you managed to reload the gallery page before the change was propagated, which could make it re-cache a stale record. I put it some extra code to make it rebuild the cached records from the main database instead of just invalidating it, which should prevent that.

Edit: There does seem to be some other caching weirdness with those particular galleries, I'll have to take a closer look at it.

Edit 2: There was another caching issue specific to the gallery page and the black favorite category. Should be fixed now. You can re-rate or re-favorite the gallery to force a cache refresh if you want to test it.

Yep, favouriting the gallery again fixes the issue now. Just to make sure i re-tested with a clean cache and it still works. Thanks for the fix.