[X] My Assistant

I think I found a bug.

While holding Shift to disable hover mode, it seem right click is also disabled.

Using firefox 31.0 with Geasemonkey 2.1

This post has been edited by Veince: Aug 20 2014, 19:33

I think I found a bug.

While holding Shift to disable hover mode, it seem right click is also disabled.

Using firefox 31.0 with Geasemonkey 2.1

That's intended behaviours, hold shift/ctr/ or alt will disable all modes of SpellSpam

This post has been edited by holy_demon: Aug 21 2014, 00:15

[MagRedw38]Magnificent Arctic Redwood Staff of Focus 40k
[Phase10]Exquisite Onyx Phase Cap of Freyr
[Phase46]Exquisite Zircon Phase Robe of Freyr
[Phase65]Exquisite Ruby Phase Gloves of Freyr
[Phase90]Exquisite Phase Pants of Freyr
[Phase132]Exquisite Cobalt Phase Shoes of Freyr

Send over with COD, thank you~

Sent

[ExqPow0]Exquisite Power Helmet of Balance
[ExqPow42]Exquisite Amber Power Armor of Balance
[ExqPow13]Exquisite Mithril Power Gauntlets of Protection
[ExqPow47]Exquisite Power Leggings of Balance
[ExqPow24]Exquisite Power Boots of Balance

Please send over with COD~

[Rapier12]Exquisite Arctic Rapier of Slaughter20k

COD please.

That's intended behaviours, hold shift/ctr/ or alt will disable all modes of SpellSpam

Wait.. in 3.5 patch note I'm seeing

- Ctr, Alt disables the script temporarily. Shift now only disables hover mode.

I just test it out. While holding shift most of the time it does disable hover mode. But I can still use Left mouse and Middle mouse spell spam. And the hover mode will be renable after that even I'm still holding shift.

I actually prefer if shift will only disable the hover mode. Because then still spell spam other spell on mouse.

[ExqPow0]Exquisite Power Helmet of Balance
[ExqPow42]Exquisite Amber Power Armor of Balance
[ExqPow13]Exquisite Mithril Power Gauntlets of Protection
[ExqPow47]Exquisite Power Leggings of Balance
[ExqPow24]Exquisite Power Boots of Balance

Please send over with COD~

[Rapier12]Exquisite Arctic Rapier of Slaughter20k

COD please.

All sent, thanks (IMG:[invalid] style_emoticons/default/smile.gif)

Wait.. in 3.5 patch note I'm seeing
I just test it out. While holding shift most of the time it does disable hover mode. But I can still use Left mouse and Middle mouse spell spam. And the hover mode will be renable after that even I'm still holding shift.

I actually prefer if shift will only disable the hover mode. Because then still spell spam other spell on mouse.

Oh yeah, I forgot what I wrote.

Can you elaborate more, like what is your profile and does it occur all the time or just sometimes?

Hello, I want to buy this:

[SupPow3]Superior Power Gauntlets of Slaughter

10k sent.

[Shield-19]Exquisite Force Shield of Warding

cod me this one please

Oh yeah, I forgot what I wrote.

Can you elaborate more, like what is your profile and does it occur all the time or just sometimes?

My current profile is

Num : Health Gem;Mana Gem;Spirit Gem; Fimbulvetr; Blizzard; Freeze
Click : Weaken
mClick : Cure; Full-Cure; Defend
rClick : Imperil
Hover : $HP>45;$MP>15;Health Gem;Mana Gem;Spirit Gem; Fimbulvetr; Blizzard; Freeze


1. Shift also disable rClick.

While holding shift, rClick will give me a dropdown menu list instead of using Imperil. This seem to happen 10 out of 10 time.


2. Hover spell spam reactivate after mClick, lClick spell spam.

I think I might have found the cause of this.

CODE

if (spell && number >= 0 && number < 10) {

with

CODE

e.stopPropagation();
if (spell && number >= 0 && number < 10) {

to disable numkey

This seem to be the cause since it doesn't happen anymore after I remove that line.

I found out that while adding

CODE

e.stopPropagation();

allow me to stop numkey spell spam when condition failed, a couple bugs occur.

Another bug I found when adding that line is that I can't use F1-F12 for hotkey potions anymore.
This happen only for

CODE

e.stopPropagation();
if (spell && number >= 0 && number < 10) {

but not

CODE

if (profile.mode.click && e.button === 0 && !e.altKey && !e.ctrlKey && isEnabled) {
e.stopPropagation();

Currently I'm working around the shift key by having another profile with the same spell but disable hover so it's not a big deal (IMG:[invalid] style_emoticons/default/smile.gif)

BTW I did test the first bug with a new clean script straight from download without editting anything, in case that confuse you.

This post has been edited by Veince: Aug 22 2014, 19:12

WTB

rapier15
shade61
shade19
shade34

COD please!

Well if you want to disable them completely when condition fails, you replace

CODE

if (spell && number >= 0 && number < 10) {

with

CODE

e.stopPropagation();
if (spell && number >= 0 && number < 10) {

to disable numkey

and

CODE

if (profile.mode.click && e.button === 0 && !e.altKey && !e.ctrlKey && isEnabled) {

with

CODE

if (profile.mode.click && e.button === 0 && !e.altKey && !e.ctrlKey && isEnabled) {
e.stopPropagation();

to disable left click

This work well , thank (IMG:[invalid] style_emoticons/default/smile.gif)
The only problem is that it also disable the F1-F12 key for pots completely.

Another issue,
my setting=

CODE

mode: {num: true, click: true, mclick: false, rclick: true, hover: false},
spell: {num: "$HP>49; Health Gem; Mana Gem; Spirit Gem; Mystic Gem; Paradise; Banishment; Smite", click: "Imperil", mclick: "Cure", rclick: "Heroic Mana Potion", hover: ""}

It never use Health Gem.

This post has been edited by Colman: Aug 24 2014, 20:00

This work well , thank (IMG:[invalid] style_emoticons/default/smile.gif)
The only problem is that it also disable the F1-F12 key for pots completely.

Another issue,
my setting=

CODE

mode: {num: true, click: true, mclick: false, rclick: true, hover: false},
spell: {num: "$HP>49; Health Gem; Mana Gem; Spirit Gem; Mystic Gem; Paradise; Banishment; Smite", click: "Imperil", mclick: "Cure", rclick: "Heroic Mana Potion", hover: ""}

It never use Health Gem.

I've just discovered that too. It seem that you can't have " "(space bar) between "$HP>49;" and "Health Gem;"

Try ""$HP>49;Health Gem;" instead.

[Shield-19]Exquisite Force Shield of Warding

cod me this one please

WTB

rapier15
shade61
shade19
shade34

COD please!

Sent,thanks (IMG:[invalid] style_emoticons/default/smile.gif)

My current profile is

Num : Health Gem;Mana Gem;Spirit Gem; Fimbulvetr; Blizzard; Freeze
Click : Weaken
mClick : Cure; Full-Cure; Defend
rClick : Imperil
Hover : $HP>45;$MP>15;Health Gem;Mana Gem;Spirit Gem; Fimbulvetr; Blizzard; Freeze
1. Shift also disable rClick.

While holding shift, rClick will give me a dropdown menu list instead of using Imperil. This seem to happen 10 out of 10 time.
2. Hover spell spam reactivate after mClick, lClick spell spam.

I think I might have found the cause of this.
This seem to be the cause since it doesn't happen anymore after I remove that line.

I found out that while adding

CODE

e.stopPropagation();

allow me to stop numkey spell spam when condition failed, a couple bugs occur.

Another bug I found when adding that line is that I can't use F1-F12 for hotkey potions anymore.
This happen only for

CODE

e.stopPropagation();
if (spell && number >= 0 && number < 10) {

CODE

if (profile.mode.click && e.button === 0 && !e.altKey && !e.ctrlKey && isEnabled) {
e.stopPropagation();

Currently I'm working around the shift key by having another profile with the same spell but disable hover so it's not a big deal (IMG:[invalid] style_emoticons/default/smile.gif)

BTW I did test the first bug with a new clean script straight from download without editting anything, in case that confuse you.

1. Cannot reproduce the 1st one. Though, just to make sure, is Imperil on cooldown by any chance, cos that's also condition fail, and the script will not stop the default behavior (context menu). If that's not the case, can you open CTRL+SHIFT+J and copy out the content of the new Window so I can debug?

2. If condition fails, the script will resume the default behavior (normal attack). That's kinda intentional, though it's bad design, I guess (IMG:[invalid] style_emoticons/default/heh.gif)

I will address the F1-F12 below

This work well , thank (IMG:[invalid] style_emoticons/default/smile.gif)
The only problem is that it also disable the F1-F12 key for pots completely.

Another issue,
my setting=

CODE

mode: {num: true, click: true, mclick: false, rclick: true, hover: false},
spell: {num: "$HP>49; Health Gem; Mana Gem; Spirit Gem; Mystic Gem; Paradise; Banishment; Smite", click: "Imperil", mclick: "Cure", rclick: "Heroic Mana Potion", hover: ""}

It never use Health Gem.

Well the correct fix should be

CODE

if (number >= 0 && number < 10) {
e.stopPropagation();
if (spell){
   //code here
}
}

You make an exra block of code so you need to have that closing }. It's kinda confusing

Alternatively you can do something like this

CODE

if (number >= 0 && number < 10&& !e.stopPropagation() && spell){

But that's kinda hack-ish since I'm assuming the browser implementation of stopPropagation to not return anything. And good coding practice (and IRL) dictates to never assume anything. (IMG:[invalid] style_emoticons/default/wink.gif)

Yeha the second bug is because my regexp overlooks trailing white space.

I will fix that and implement that 2 stopPropagation fix in 1-2 days, when I get away from Skyrim (IMG:[invalid] style_emoticons/default/tongue.gif) For now, deleting the white space before Health Gem like Veince suggested or replace this

CODE

var checkedName = name.replace(/\s*([^,;]*\$[^,;]+)\s*[,;]*/g, function(match, cond) {

with

CODE

var checkedName = name.replace(/\s*([^,;]*\$[^,;]+)\s*[,;]*\s*/g, function(match, cond) {

3 characters (IMG:[invalid] style_emoticons/default/heh.gif)

This post has been edited by holy_demon: Aug 25 2014, 10:58

[MagWaki15
This one, please ^^ CoD

I will fix that and implement that 2 stopPropagation fix in 1-2 days, when I get away from Skyrim (IMG:[invalid] style_emoticons/default/tongue.gif) For now, deleting the white space before Health Gem like Veince suggested or replace this

The "e.stopPropagation();" also stop the action from Num_pad so I have to assign MagNet to mid-click (IMG:[invalid] style_emoticons/default/heh.gif)
Not enough key for ether thief now (IMG:[invalid] style_emoticons/default/faint.gif)

The "e.stopPropagation();" also stop the action from Num_pad so I have to assign MagNet to mid-click (IMG:[invalid] style_emoticons/default/heh.gif)
Not enough key for ether thief now (IMG:[invalid] style_emoticons/default/faint.gif)

hmm hmm come to think of it would it be a good idea to use CTRL/ALT to cycle through the rotation (eg: CTRL disables, ALT skips to 2nd spells, both CTRL+ALT skips to 3rd spells). Now you can have 2 times the number of keys (IMG:[invalid] style_emoticons/default/tongue.gif)

Or you can just set up another profile with Magnet on its numkey =_=

This post has been edited by holy_demon: Aug 25 2014, 12:57

[MagWaki15
This one, please ^^ CoD

Sent, thanks (IMG:[invalid] style_emoticons/default/smile.gif)


This post has been edited by holy_demon: Aug 26 2014, 01:03

[Shield-16]Exquisite Cobalt Force Shield of Protection 40k
[Rapier26]Exquisite Tempestuous Rapier of Slaughter 20k

[ExqPowSla10]Exquisite Power Armor of Slaughter 100k
[ExqPowSla7]Exquisite Power Helmet of Slaughter 100k

Send over with COD, thank you

This post has been edited by 파르톤: Aug 25 2014, 13:25

Sent, thanks (IMG:[invalid] style_emoticons/default/smile.gif)

No, thank you)
It's great!